Partial revert of commits 1ce8b9bc279468964deeb01ae6b4e9c15e52f625 (and
c296187ea9c950f544b8b69c8184b436f2743955).
... | ... |
@@ -17,12 +17,11 @@ WITH REGARD TO THIS SOFTWARE. |
17 | 17 |
pc: program counter. sp: ptr to src stack ptr. kptr: "keep" mode copy of src stack ptr. |
18 | 18 |
x,y: macro in params. d: macro in device. j,k,dev: macro temp variables. o: macro out param. */ |
19 | 19 |
|
20 |
-#define FAULT(s, n) { errcode = n * 2 + (s == &u->rst); goto fault; } |
|
21 |
-#define PUSH8(s, x) { if(s->ptr == 0xff) { FAULT(s, 2) } s->dat[s->ptr++] = (x); } |
|
22 |
-#define PUSH16(s, x) { if((j = s->ptr) >= 0xfe) { FAULT(s, 2) } k = (x); s->dat[j] = k >> 8; s->dat[j + 1] = k; s->ptr = j + 2; } |
|
20 |
+#define PUSH8(s, x) { if(s->ptr == 0xff) { errcode = 2; goto err; } s->dat[s->ptr++] = (x); } |
|
21 |
+#define PUSH16(s, x) { if((j = s->ptr) >= 0xfe) { errcode = 2; goto err; } k = (x); s->dat[j] = k >> 8; s->dat[j + 1] = k; s->ptr = j + 2; } |
|
23 | 22 |
#define PUSH(s, x) { if(bs) { PUSH16(s, (x)) } else { PUSH8(s, (x)) } } |
24 |
-#define POP8(o) { if(!(j = *sp)) { FAULT(src, 1) } o = (Uint16)src->dat[--j]; *sp = j; } |
|
25 |
-#define POP16(o) { if((j = *sp) <= 1) { FAULT(src, 1) } o = src->dat[j - 1]; o += src->dat[j - 2] << 8; *sp = j - 2; } |
|
23 |
+#define POP8(o) { if(!(j = *sp)) { errcode = 1; goto err; } o = (Uint16)src->dat[--j]; *sp = j; } |
|
24 |
+#define POP16(o) { if((j = *sp) <= 1) { errcode = 1; goto err; } o = src->dat[j - 1]; o += src->dat[j - 2] << 8; *sp = j - 2; } |
|
26 | 25 |
#define POP(o) { if(bs) { POP16(o) } else { POP8(o) } } |
27 | 26 |
#define POKE(x, y) { if(bs) { u->ram[(x)] = (y) >> 8; u->ram[(x) + 1] = (y); } else { u->ram[(x)] = y; } } |
28 | 27 |
#define PEEK16(o, x) { o = (u->ram[(x)] << 8) + u->ram[(x) + 1]; } |
... | ... |
@@ -90,7 +89,7 @@ uxn_eval(Uxn *u, Uint16 pc) |
90 | 89 |
case 0x18: /* ADD */ POP(a) POP(b) PUSH(src, b + a) break; |
91 | 90 |
case 0x19: /* SUB */ POP(a) POP(b) PUSH(src, b - a) break; |
92 | 91 |
case 0x1a: /* MUL */ POP(a) POP(b) PUSH(src, (Uint32)b * a) break; |
93 |
- case 0x1b: /* DIV */ POP(a) POP(b) if(a == 0) { FAULT(src, 3) } PUSH(src, b / a) break; |
|
92 |
+ case 0x1b: /* DIV */ POP(a) POP(b) if(a == 0) { errcode = 3; goto err; } PUSH(src, b / a) break; |
|
94 | 93 |
case 0x1c: /* AND */ POP(a) POP(b) PUSH(src, b & a) break; |
95 | 94 |
case 0x1d: /* ORA */ POP(a) POP(b) PUSH(src, b | a) break; |
96 | 95 |
case 0x1e: /* EOR */ POP(a) POP(b) PUSH(src, b ^ a) break; |
... | ... |
@@ -99,8 +98,11 @@ uxn_eval(Uxn *u, Uint16 pc) |
99 | 98 |
} |
100 | 99 |
return 1; |
101 | 100 |
|
102 |
-fault: |
|
103 |
- return uxn_halt(u, errcode >> 1, (errcode & 1) == 0 ? "Working-stack" : "Return-stack", pc - 1); |
|
101 |
+err: |
|
102 |
+ if ((instr & 0x40 ? 1 : 0) ^ (errcode == 2 && ((instr & 0x1f) == 0x0e || (instr & 0x1f) == 0x0f))) |
|
103 |
+ return uxn_halt(u, errcode, "Return-stack", pc - 1); |
|
104 |
+ else |
|
105 |
+ return uxn_halt(u, errcode, "Working-stack", pc - 1); |
|
104 | 106 |
} |
105 | 107 |
|
106 | 108 |
/* clang-format on */ |