Browse code

Refactor uxn.c.

cancel authored on 02/01/2022 23:03:06 • Andrew Alderwick committed on 02/01/2022 23:03:06
Showing 1 changed files
... ...
@@ -3,6 +3,7 @@
3 3
 /*
4 4
 Copyright (u) 2021 Devine Lu Linvega
5 5
 Copyright (u) 2021 Andrew Alderwick
6
+Copyright (u) 2022 Andrew Richards
6 7
 
7 8
 Permission to use, copy, modify, and distribute this software for any
8 9
 purpose with or without fee is hereby granted, provided that the above
... ...
@@ -12,125 +13,97 @@ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
12 13
 WITH REGARD TO THIS SOFTWARE.
13 14
 */
14 15
 
15
-#define MODE_SHORT 0x20
16
-#define MODE_RETURN 0x40
17
-#define MODE_KEEP 0x80
18
-
19
-#pragma mark - Operations
20
-
21 16
 /* clang-format off */
22 17
 
23
-/* Utilities */
24
-static void   (*uxn_push)(Stack *s, Uint16 a);
25
-static Uint16 (*uxn_pop8)(Stack *s);
26
-static Uint16 (*uxn_pop)(Stack *s);
27
-static void   (*uxn_poke)(Uint8 *m, Uint16 a, Uint16 b);
28
-static Uint16 (*uxn_peek)(Uint8 *m, Uint16 a);
29
-static void   (*uxn_devw)(Device *d, Uint8 a, Uint16 b);
30
-static Uint16 (*uxn_devr)(Device *d, Uint8 a);
31
-static void   (*uxn_warp)(Uxn *u, Uint16 a);
32
-static void   (*uxn_pull)(Uxn *u);
33
-/* byte mode */
34
-static void   push8(Stack *s, Uint16 a) { if(s->ptr == 0xff) { s->error = 2; return; } s->dat[s->ptr++] = a; }
35
-static Uint16 pop8k(Stack *s) { if(s->kptr == 0) { s->error = 1; return 0; } return s->dat[--s->kptr]; }
36
-static Uint16 pop8d(Stack *s) { if(s->ptr == 0) { s->error = 1; return 0; } return s->dat[--s->ptr]; }
37
-static void   poke8(Uint8 *m, Uint16 a, Uint16 b) { m[a] = b; }
38
-static Uint16 peek8(Uint8 *m, Uint16 a) { return m[a]; }
39
-static void   devw8(Device *d, Uint8 a, Uint16 b) { d->dat[a & 0xf] = b; d->deo(d, a & 0x0f); }
40
-static Uint16 devr8(Device *d, Uint8 a) { return d->dei(d, a & 0x0f); }
41
-static void   warp8(Uxn *u, Uint16 a){ u->ram.ptr += (Sint8)a; }
42
-static void   pull8(Uxn *u){ push8(u->src, peek8(u->ram.dat, u->ram.ptr++)); }
43
-/* short mode */
44
-static void   push16(Stack *s, Uint16 a) { push8(s, a >> 8); push8(s, a); }
45
-static Uint16 pop16(Stack *s) { Uint8 a = uxn_pop8(s), b = uxn_pop8(s); return a + (b << 8); }
46
-	   void   poke16(Uint8 *m, Uint16 a, Uint16 b) { poke8(m, a, b >> 8); poke8(m, a + 1, b); }
47
-	   Uint16 peek16(Uint8 *m, Uint16 a) { return (peek8(m, a) << 8) + peek8(m, a + 1); }
48
-static void   devw16(Device *d, Uint8 a, Uint16 b) { devw8(d, a, b >> 8); devw8(d, a + 1, b); }
49
-static Uint16 devr16(Device *d, Uint8 a) { return (devr8(d, a) << 8) + devr8(d, a + 1); }
50
-static void   warp16(Uxn *u, Uint16 a){ u->ram.ptr = a; }
51
-static void   pull16(Uxn *u){ push16(u->src, peek16(u->ram.dat, u->ram.ptr++)); u->ram.ptr++; }
18
+#define PUSH8(s, v) { if(s->ptr == 0xff) { errcode = 2; goto err; } s->dat[s->ptr++] = (v); }
19
+#define PUSH16(s, v) { if((tmp = s->ptr) >= 0xfe) { errcode = 2; goto err; } s->dat[tmp] = (v) >> 8; s->dat[tmp + 1] = (v); s->ptr = tmp + 2; }
20
+#define PUSH(s, v) { if(bs) { PUSH16(s, (v)) } else { PUSH8(s, (v)) } }
21
+#define POP8(o) { if(*pptr == 0) { errcode = 1; goto err; } o = (Uint16)src->dat[--(*pptr)]; }
22
+#define POP16(o) { if((tmp = *pptr) <= 1) { errcode = 1; goto err; } o = src->dat[tmp - 1]; o += src->dat[tmp - 2] << 8; *pptr = tmp - 2; }
23
+#define POP(o) { if(bs) { POP16(o) } else { POP8(o) } }
24
+#define POKE(x, y) { if(bs) { u->ram.dat[(x)] = (y) >> 8; u->ram.dat[(x) + 1] = (y); } else { u->ram.dat[(x)] = y; }}
25
+#define PEEK16(o, x) { o = (u->ram.dat[(x)] << 8) + u->ram.dat[(x) + 1]; }
26
+#define PEEK(o, x) { if(bs) { PEEK16(o, x) } else { o = u->ram.dat[(x)]; }}
27
+#define DEVR(o, d, v) { dev = (d); o = dev->dei(dev, (v) & 0x0f); if(bs) { o = (o << 8) + dev->dei(dev, ((v) + 1) & 0x0f); } }
28
+#define DEVW8(x, y) { dev->dat[(x) & 0xf] = y; dev->deo(dev, (x) & 0x0f); }
29
+#define DEVW(d, x, y) { dev = (d); if(bs) { DEVW8((x), (y) >> 8); DEVW8((x) + 1, (y)); } else { DEVW8((x), (y)) } }
30
+#define WARP(x) { if(bs) u->ram.ptr = (x); else u->ram.ptr += (Sint8)(x); }
52 31
 
53
-#pragma mark - Core
32
+void   poke16(Uint8 *m, Uint16 a, Uint16 b) { m[a] = b >> 8; m[a + 1] = b; }
33
+Uint16 peek16(Uint8 *m, Uint16 a) { Uint16 r = m[a] << 8; return r + m[a + 1]; }
54 34
 
55 35
 int
56 36
 uxn_eval(Uxn *u, Uint16 vec)
57 37
 {
58
-	Uint8 instr;
59
-	Uint16 a,b,c;
38
+	Uint8 instr, errcode, kptr, *pptr;
39
+	Uint16 a,b,c, discard;
40
+	int bs, tmp;
41
+	Device *dev;
60 42
 	if(!vec || u->dev[0].dat[0xf])
61 43
 		return 0;
62 44
 	u->ram.ptr = vec;
63 45
 	if(u->wst.ptr > 0xf8) u->wst.ptr = 0xf8;
64 46
 	while((instr = u->ram.dat[u->ram.ptr++])) {
47
+		Stack *src, *dst;
65 48
 		/* Return Mode */
66
-		if(instr & MODE_RETURN) {
67
-			u->src = &u->rst; 
68
-			u->dst = &u->wst;
49
+		if(instr & 0x40) {
50
+			src = &u->rst; dst = &u->wst;
69 51
 		} else {
70
-			u->src = &u->wst; 
71
-			u->dst = &u->rst;
52
+			src = &u->wst; dst = &u->rst;
72 53
 		}
73 54
 		/* Keep Mode */
74
-		if(instr & MODE_KEEP) {
75
-			uxn_pop8 = pop8k;
76
-			u->src->kptr = u->src->ptr;
55
+		if(instr & 0x80) {
56
+			kptr = src->ptr;
57
+			pptr = &kptr;
77 58
 		} else {
78
-			uxn_pop8 = pop8d;
59
+			pptr = &src->ptr;
79 60
 		}
80 61
 		/* Short Mode */
81
-		if(instr & MODE_SHORT) {
82
-			uxn_push = push16; uxn_pop = pop16;
83
-			uxn_poke = poke16; uxn_peek = peek16;
84
-			uxn_devw = devw16; uxn_devr = devr16;
85
-			uxn_warp = warp16; uxn_pull = pull16;
86
-		} else {
87
-			uxn_push = push8; uxn_pop = uxn_pop8;
88
-			uxn_poke = poke8; uxn_peek = peek8;
89
-			uxn_devw = devw8; uxn_devr = devr8;
90
-			uxn_warp = warp8; uxn_pull = pull8;
91
-		}
62
+		bs = instr & 0x20 ? 1 : 0;
92 63
 		switch(instr & 0x1f){
93 64
 			/* Stack */
94
-			case 0x00: /* LIT */ uxn_pull(u); break;
95
-			case 0x01: /* INC */ a = uxn_pop(u->src); uxn_push(u->src, a + 1); break;
96
-			case 0x02: /* POP */ uxn_pop(u->src); break;
97
-			case 0x03: /* DUP */ a = uxn_pop(u->src); uxn_push(u->src, a); uxn_push(u->src, a); break;
98
-			case 0x04: /* NIP */ a = uxn_pop(u->src); uxn_pop(u->src); uxn_push(u->src, a); break;
99
-			case 0x05: /* SWP */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, a); uxn_push(u->src, b); break;
100
-			case 0x06: /* OVR */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, b); uxn_push(u->src, a); uxn_push(u->src, b); break;
101
-			case 0x07: /* ROT */ a = uxn_pop(u->src), b = uxn_pop(u->src), c = uxn_pop(u->src); uxn_push(u->src, b); uxn_push(u->src, a); uxn_push(u->src, c); break;
65
+			case 0x00: /* LIT */ if(bs) { PEEK16(a, u->ram.ptr); PUSH16(src, a); u->ram.ptr += 2; }
66
+			                     else   { a = u->ram.dat[u->ram.ptr++]; PUSH8(src, a); } break;
67
+			case 0x01: /* INC */ POP(a); PUSH(src, a + 1); break;
68
+			case 0x02: /* POP */ POP(discard); break;
69
+			case 0x03: /* DUP */ POP(a); PUSH(src, a); PUSH(src, a); break;
70
+			case 0x04: /* NIP */ POP(a); POP(discard); PUSH(src, a); break;
71
+			case 0x05: /* SWP */ POP(a); POP(b); PUSH(src, a); PUSH(src, b); break;
72
+			case 0x06: /* OVR */ POP(a); POP(b); PUSH(src, b); PUSH(src, a); PUSH(src, b); break;
73
+			case 0x07: /* ROT */ POP(a); POP(b); POP(c); PUSH(src, b); PUSH(src, a); PUSH(src, c); break;
102 74
 			/* Logic */
103
-			case 0x08: /* EQU */ a = uxn_pop(u->src), b = uxn_pop(u->src); push8(u->src, b == a); break;
104
-			case 0x09: /* NEQ */ a = uxn_pop(u->src), b = uxn_pop(u->src); push8(u->src, b != a); break;
105
-			case 0x0a: /* GTH */ a = uxn_pop(u->src), b = uxn_pop(u->src); push8(u->src, b > a); break;
106
-			case 0x0b: /* LTH */ a = uxn_pop(u->src), b = uxn_pop(u->src); push8(u->src, b < a); break;
107
-			case 0x0c: /* JMP */ a = uxn_pop(u->src); uxn_warp(u, a); break;
108
-			case 0x0d: /* JCN */ a = uxn_pop(u->src); if(uxn_pop8(u->src)) uxn_warp(u, a); break;
109
-			case 0x0e: /* JSR */ a = uxn_pop(u->src); push16(u->dst, u->ram.ptr); uxn_warp(u, a); break;
110
-			case 0x0f: /* STH */ a = uxn_pop(u->src); uxn_push(u->dst, a); break;
75
+			case 0x08: /* EQU */ POP(a); POP(b); PUSH8(src, b == a); break;
76
+			case 0x09: /* NEQ */ POP(a); POP(b); PUSH8(src, b != a); break;
77
+			case 0x0a: /* GTH */ POP(a); POP(b); PUSH8(src, b > a); break;
78
+			case 0x0b: /* LTH */ POP(a); POP(b); PUSH8(src, b < a); break;
79
+			case 0x0c: /* JMP */ POP(a); WARP(a); break;
80
+			case 0x0d: /* JCN */ POP(a); POP8(b); if(b) WARP(a); break;
81
+			case 0x0e: /* JSR */ POP(a); PUSH16(dst, u->ram.ptr); WARP(a); break;
82
+			case 0x0f: /* STH */ POP(a); PUSH(dst, a); break;
111 83
 			/* Memory */
112
-			case 0x10: /* LDZ */ a = uxn_pop8(u->src); uxn_push(u->src, uxn_peek(u->ram.dat, a)); break;
113
-			case 0x11: /* STZ */ a = uxn_pop8(u->src); b = uxn_pop(u->src); uxn_poke(u->ram.dat, a, b); break;
114
-			case 0x12: /* LDR */ a = uxn_pop8(u->src); uxn_push(u->src, uxn_peek(u->ram.dat, u->ram.ptr + (Sint8)a)); break;
115
-			case 0x13: /* STR */ a = uxn_pop8(u->src); b = uxn_pop(u->src); uxn_poke(u->ram.dat, u->ram.ptr + (Sint8)a, b); break;
116
-			case 0x14: /* LDA */ a = pop16(u->src); uxn_push(u->src, uxn_peek(u->ram.dat, a)); break;
117
-			case 0x15: /* STA */ a = pop16(u->src); b = uxn_pop(u->src); uxn_poke(u->ram.dat, a, b); break;
118
-			case 0x16: /* DEI */ a = uxn_pop8(u->src); uxn_push(u->src, uxn_devr(&u->dev[a >> 4], a)); break;
119
-			case 0x17: /* DEO */ a = uxn_pop8(u->src); b = uxn_pop(u->src); uxn_devw(&u->dev[a >> 4], a, b); break;
84
+			case 0x10: /* LDZ */ POP8(a); PEEK(b, a); PUSH(src, b); break;
85
+			case 0x11: /* STZ */ POP8(a); POP(b); POKE(a, b); break;
86
+			case 0x12: /* LDR */ POP8(a); PEEK(b, u->ram.ptr + (Sint8)a); PUSH(src, b); break;
87
+			case 0x13: /* STR */ POP8(a); POP(b); c = u->ram.ptr + (Sint8)a; POKE(c, b); break;
88
+			case 0x14: /* LDA */ POP16(a); PEEK(b, a); PUSH(src, b); break;
89
+			case 0x15: /* STA */ POP16(a); POP(b); POKE(a, b); break;
90
+			case 0x16: /* DEI */ POP8(a); DEVR(b, &u->dev[a >> 4], a); PUSH(src, b); break;
91
+			case 0x17: /* DEO */ POP8(a); POP(b); DEVW(&u->dev[a >> 4], a, b); break;
120 92
 			/* Arithmetic */
121
-			case 0x18: /* ADD */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, b + a); break;
122
-			case 0x19: /* SUB */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, b - a); break;
123
-			case 0x1a: /* MUL */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, (Uint32)b * a); break;
124
-			case 0x1b: /* DIV */ a = uxn_pop(u->src), b = uxn_pop(u->src); if(a == 0) { u->src->error = 3; a = 1; } uxn_push(u->src, b / a); break;
125
-			case 0x1c: /* AND */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, b & a); break;
126
-			case 0x1d: /* ORA */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, b | a); break;
127
-			case 0x1e: /* EOR */ a = uxn_pop(u->src), b = uxn_pop(u->src); uxn_push(u->src, b ^ a); break;
128
-			case 0x1f: /* SFT */ a = uxn_pop8(u->src), b = uxn_pop(u->src); uxn_push(u->src, b >> (a & 0x0f) << ((a & 0xf0) >> 4)); break;
93
+			case 0x18: /* ADD */ POP(a); POP(b); PUSH(src, b + a); break;
94
+			case 0x19: /* SUB */ POP(a); POP(b); PUSH(src, b - a); break;
95
+			case 0x1a: /* MUL */ POP(a); POP(b); PUSH(src, (Uint32)b * a); break;
96
+			case 0x1b: /* DIV */ POP(a); POP(b); if(a == 0) { errcode = 3; goto err; } PUSH(src, b / a); break;
97
+			case 0x1c: /* AND */ POP(a); POP(b); PUSH(src, b & a); break;
98
+			case 0x1d: /* ORA */ POP(a); POP(b); PUSH(src, b | a); break;
99
+			case 0x1e: /* EOR */ POP(a); POP(b); PUSH(src, b ^ a); break;
100
+			case 0x1f: /* SFT */ POP8(a); POP(b); c = b >> (a & 0x0f) << ((a & 0xf0) >> 4); PUSH(src, c); break;
129 101
 		}
130
-		if(u->wst.error) return uxn_halt(u, u->wst.error, "Working-stack", instr);
131
-		if(u->rst.error) return uxn_halt(u, u->rst.error, "Return-stack", instr);
132 102
 	}
133 103
 	return 1;
104
+
105
+err:
106
+	return uxn_halt(u, errcode, "Stack", instr);
134 107
 }
135 108
 
136 109
 /* clang-format on */