Browse code

Remove jump-based infinite loop detection.

Andrew Alderwick authored on 23/01/2022 11:17:07
Showing 4 changed files
... ...
@@ -29,12 +29,12 @@ WITH REGARD TO THIS SOFTWARE.
29 29
 #define DEVR(o, d, x) { dev = (d); o = dev->dei(dev, (x) & 0x0f); if(bs) { o = (o << 8) + dev->dei(dev, ((x) + 1) & 0x0f); } }
30 30
 #define DEVW8(x, y) { dev->dat[(x) & 0xf] = y; dev->deo(dev, (x) & 0x0f); }
31 31
 #define DEVW(d, x, y) { dev = (d); if(bs) { DEVW8((x), (y) >> 8); DEVW8((x) + 1, (y)); } else { DEVW8((x), (y)) } }
32
+#define WARP(x) { if(bs) pc = (x); else pc += (Sint8)(x); }
32 33
 
33 34
 int
34 35
 uxn_eval(Uxn *u, Uint16 pc)
35 36
 {
36 37
 	unsigned int a, b, c, j, k, bs, instr, errcode;
37
-	Uint16 warp_count = 0;
38 38
 	Uint8 kptr, *sp;
39 39
 	Stack *src, *dst;
40 40
 	Device *dev;
... ...
@@ -59,46 +59,42 @@ uxn_eval(Uxn *u, Uint16 pc)
59 59
 		switch(instr & 0x1f) {
60 60
 		/* Stack */
61 61
 		case 0x00: /* LIT */ if(bs) { PEEK16(a, pc) PUSH16(src, a) pc += 2; }
62
-		                     else   { a = u->ram[pc]; PUSH8(src, a) pc++; } continue;
63
-		case 0x01: /* INC */ POP(a) PUSH(src, a + 1) continue;
64
-		case 0x02: /* POP */ POP(a) continue;
65
-		case 0x03: /* DUP */ POP(a) PUSH(src, a) PUSH(src, a) continue;
66
-		case 0x04: /* NIP */ POP(a) POP(b) PUSH(src, a) continue;
67
-		case 0x05: /* SWP */ POP(a) POP(b) PUSH(src, a) PUSH(src, b) continue;
68
-		case 0x06: /* OVR */ POP(a) POP(b) PUSH(src, b) PUSH(src, a) PUSH(src, b) continue;
69
-		case 0x07: /* ROT */ POP(a) POP(b) POP(c) PUSH(src, b) PUSH(src, a) PUSH(src, c) continue;
62
+		                     else   { a = u->ram[pc]; PUSH8(src, a) pc++; } break;
63
+		case 0x01: /* INC */ POP(a) PUSH(src, a + 1) break;
64
+		case 0x02: /* POP */ POP(a) break;
65
+		case 0x03: /* DUP */ POP(a) PUSH(src, a) PUSH(src, a) break;
66
+		case 0x04: /* NIP */ POP(a) POP(b) PUSH(src, a) break;
67
+		case 0x05: /* SWP */ POP(a) POP(b) PUSH(src, a) PUSH(src, b) break;
68
+		case 0x06: /* OVR */ POP(a) POP(b) PUSH(src, b) PUSH(src, a) PUSH(src, b) break;
69
+		case 0x07: /* ROT */ POP(a) POP(b) POP(c) PUSH(src, b) PUSH(src, a) PUSH(src, c) break;
70 70
 		/* Logic */
71
-		case 0x08: /* EQU */ POP(a) POP(b) PUSH8(src, b == a) continue;
72
-		case 0x09: /* NEQ */ POP(a) POP(b) PUSH8(src, b != a) continue;
73
-		case 0x0a: /* GTH */ POP(a) POP(b) PUSH8(src, b > a) continue;
74
-		case 0x0b: /* LTH */ POP(a) POP(b) PUSH8(src, b < a) continue;
75
-		case 0x0c: /* JMP */ POP(a) break;
76
-		case 0x0d: /* JCN */ POP(a) POP8(b) if(b) break; continue;
77
-		case 0x0e: /* JSR */ POP(a) PUSH16(dst, pc) break;
78
-		case 0x0f: /* STH */ POP(a) PUSH(dst, a) continue;
71
+		case 0x08: /* EQU */ POP(a) POP(b) PUSH8(src, b == a) break;
72
+		case 0x09: /* NEQ */ POP(a) POP(b) PUSH8(src, b != a) break;
73
+		case 0x0a: /* GTH */ POP(a) POP(b) PUSH8(src, b > a) break;
74
+		case 0x0b: /* LTH */ POP(a) POP(b) PUSH8(src, b < a) break;
75
+		case 0x0c: /* JMP */ POP(a) WARP(a) break;
76
+		case 0x0d: /* JCN */ POP(a) POP8(b) if(b) WARP(a) break;
77
+		case 0x0e: /* JSR */ POP(a) PUSH16(dst, pc) WARP(a) break;
78
+		case 0x0f: /* STH */ POP(a) PUSH(dst, a) break;
79 79
 		/* Memory */
80
-		case 0x10: /* LDZ */ POP8(a) PEEK(b, a) PUSH(src, b) continue;
81
-		case 0x11: /* STZ */ POP8(a) POP(b) POKE(a, b) continue;
82
-		case 0x12: /* LDR */ POP8(a) PEEK(b, pc + (Sint8)a) PUSH(src, b) continue;
83
-		case 0x13: /* STR */ POP8(a) POP(b) c = pc + (Sint8)a; POKE(c, b) continue;
84
-		case 0x14: /* LDA */ POP16(a) PEEK(b, a) PUSH(src, b) continue;
85
-		case 0x15: /* STA */ POP16(a) POP(b) POKE(a, b) continue;
86
-		case 0x16: /* DEI */ POP8(a) DEVR(b, &u->dev[a >> 4], a) PUSH(src, b) continue;
87
-		case 0x17: /* DEO */ POP8(a) POP(b) DEVW(&u->dev[a >> 4], a, b) continue;
80
+		case 0x10: /* LDZ */ POP8(a) PEEK(b, a) PUSH(src, b) break;
81
+		case 0x11: /* STZ */ POP8(a) POP(b) POKE(a, b) break;
82
+		case 0x12: /* LDR */ POP8(a) PEEK(b, pc + (Sint8)a) PUSH(src, b) break;
83
+		case 0x13: /* STR */ POP8(a) POP(b) c = pc + (Sint8)a; POKE(c, b) break;
84
+		case 0x14: /* LDA */ POP16(a) PEEK(b, a) PUSH(src, b) break;
85
+		case 0x15: /* STA */ POP16(a) POP(b) POKE(a, b) break;
86
+		case 0x16: /* DEI */ POP8(a) DEVR(b, &u->dev[a >> 4], a) PUSH(src, b) break;
87
+		case 0x17: /* DEO */ POP8(a) POP(b) DEVW(&u->dev[a >> 4], a, b) break;
88 88
 		/* Arithmetic */
89
-		case 0x18: /* ADD */ POP(a) POP(b) PUSH(src, b + a) continue;
90
-		case 0x19: /* SUB */ POP(a) POP(b) PUSH(src, b - a) continue;
91
-		case 0x1a: /* MUL */ POP(a) POP(b) PUSH(src, (Uint32)b * a) continue;
92
-		case 0x1b: /* DIV */ POP(a) POP(b) if(a == 0) { errcode = 4; goto err; } PUSH(src, b / a) continue;
93
-		case 0x1c: /* AND */ POP(a) POP(b) PUSH(src, b & a) continue;
94
-		case 0x1d: /* ORA */ POP(a) POP(b) PUSH(src, b | a) continue;
95
-		case 0x1e: /* EOR */ POP(a) POP(b) PUSH(src, b ^ a) continue;
96
-		case 0x1f: /* SFT */ POP8(a) POP(b) c = b >> (a & 0x0f) << ((a & 0xf0) >> 4); PUSH(src, c) continue;
89
+		case 0x18: /* ADD */ POP(a) POP(b) PUSH(src, b + a) break;
90
+		case 0x19: /* SUB */ POP(a) POP(b) PUSH(src, b - a) break;
91
+		case 0x1a: /* MUL */ POP(a) POP(b) PUSH(src, (Uint32)b * a) break;
92
+		case 0x1b: /* DIV */ POP(a) POP(b) if(a == 0) { errcode = 4; goto err; } PUSH(src, b / a) break;
93
+		case 0x1c: /* AND */ POP(a) POP(b) PUSH(src, b & a) break;
94
+		case 0x1d: /* ORA */ POP(a) POP(b) PUSH(src, b | a) break;
95
+		case 0x1e: /* EOR */ POP(a) POP(b) PUSH(src, b ^ a) break;
96
+		case 0x1f: /* SFT */ POP8(a) POP(b) c = b >> (a & 0x0f) << ((a & 0xf0) >> 4); PUSH(src, c) break;
97 97
 		}
98
-
99
-		/* Jump to a */
100
-		if(bs) pc = a; else pc += (Sint8)(a);
101
-		if(!++warp_count && uxn_interrupt(u)) return uxn_halt(u, 6, pc - 1);
102 98
 	}
103 99
 	return 1;
104 100
 
... ...
@@ -51,5 +51,4 @@ typedef struct Uxn {
51 51
 int uxn_boot(Uxn *u, Uint8 *ram);
52 52
 int uxn_eval(Uxn *u, Uint16 pc);
53 53
 int uxn_halt(Uxn *u, Uint8 error, Uint16 addr);
54
-int uxn_interrupt(Uxn *u);
55 54
 Device *uxn_port(Uxn *u, Uint8 id, Uint8 (*deifn)(Device *, Uint8), void (*deofn)(Device *, Uint8));
... ...
@@ -17,13 +17,6 @@ THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
17 17
 WITH REGARD TO THIS SOFTWARE.
18 18
 */
19 19
 
20
-int
21
-uxn_interrupt(Uxn *u)
22
-{
23
-	(void)u;
24
-	return 0;
25
-}
26
-
27 20
 static int
28 21
 error(char *msg, const char *err)
29 22
 {
... ...
@@ -76,13 +76,6 @@ audio_finished_handler(UxnAudio *c)
76 76
 	SDL_PushEvent(&event);
77 77
 }
78 78
 
79
-int
80
-uxn_interrupt(Uxn *u)
81
-{
82
-	(void)u;
83
-	return 0;
84
-}
85
-
86 79
 static int
87 80
 stdin_handler(void *p)
88 81
 {